feature/bgp sessions admin flap test by PriyanshTratiya · Pull Request #21520 · sonic-net/sonic-mgmt

PriyanshTratiya · 2025-12-03T18:10:46Z

Description of PR

Summary:
Fixes # (issue)

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR #21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces.

Key Points:

Implements new high‑scale BGP admin flap test cases reusing the generalized connection‑handling logic introduced in PR #21335.
Adds parameterized flows to flap:
- Individual BGP sessions,
- All ports/sessions, at scale.
Extends helper methods to:
- Drive repeated admin shut/no‑shut cycles,
- Measure convergence and recovery time after each flap,
- Validate BGP IPv6 routes and neighbor states remain stable after repeated flaps.
Integrates the new flap scenarios with existing BGP IPv6 convergence and scale tests, keeping configuration and connection behaviors consistent with the refactored framework.
Improves logging and per‑iteration reporting for easier debugging of failures during long‑running flap cycles.

Type of change

Bug fix
Testbed and Framework(new/improvement)
[ x ] New Test case
- Skipped for non-supported platforms
Test case improvement

Back port request

Approach

What is the motivation for this PR?

To validate BGP IPv6 convergence and stability under high‑scale and repeated admin flap scenarios, we want dedicated test coverage for:

Repeated shut/no‑shut of BGP neighbors and interfaces at scale,
Ensuring routes re‑converge within expected bounds,
Detecting potential regressions in control‑plane stability and convergence times when links or sessions are frequently toggled.

How did you do it?

Added new BGP flap test flows in tests/bgp/test_ipv6_bgp_scale.py (and related helpers) that:
- Use the refactored connection control APIs (shutdown_connections, connection_type, shutdown_all_connections, etc.) to drive admin flaps.
- Allow configuration of:
  - Number of flap iterations,
  - Target connection type (session vs. port, subset vs. all),
  - Wait times between flap and verification.
- After each flap cycle, verify:
  - BGP sessions return to Established,
  - Expected IPv6 routes are fully present,
  - No unexpected route loss or long‑term neighbor instability.
Reused/refined existing helper functions for command execution, logging, and validation so that the flap tests share as much code as possible with the convergence/scale tests added.
Kept the test logic parameter‑driven to make future extensions straightforward.

How did you verify/test it?

Ran the new BGP flap tests on:
- t0-isolated-d2u510s2 topology
- Platform: Broadcom Arista-7060X6-64PE-B-C512S2
Verified:
- BGP sessions recover to Established after each flap iteration,
- IPv6 routes re‑converge as expected,
- No persistent errors or unexpected failures in the test logs.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

#21437

mssonicbld · 2025-12-03T18:10:54Z

/azp run

azure-pipelines · 2025-12-03T18:11:07Z

Azure Pipelines successfully started running 1 pipeline(s).

ansible/library/check_bgp_ipv6_routes_converged.py

mssonicbld · 2025-12-04T01:08:11Z

/azp run

azure-pipelines · 2025-12-04T01:08:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2026-01-09T11:45:54Z

Azure Pipelines successfully started running 1 pipeline(s).

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: YiFan Wang <yifan@nexthop.ai>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: Andoni Sanguesa <andoniesanguesa@gmail.com>

mssonicbld · 2026-01-30T22:32:52Z

@PriyanshTratiya PR conflicts with 202511 branch

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

weiguo-nvidia · 2026-02-09T09:24:08Z

Hi @PriyanshTratiya

Could you help cherry-pick the PR to 202511? Thanks

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>

PriyanshTratiya · 2026-02-13T22:02:37Z

@PriyanshTratiya PR conflicts with 202511 branch

#22304

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR #21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: Abhishek <abhishek@nexthop.ai>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

This PR adds the high‑scale BGP admin flap tests that build on top of the refactoring done in PR sonic-net#21335. It introduces new test cases and utilities to exercise BGP IPv6 convergence and scale behavior under repeated admin shutdown/startup (“flap”) scenarios for BGP sessions and interfaces. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>

github-actions bot requested review from cyw233, lolyu, r12f, sanjair-git, wangxin and xwjiang-ms December 3, 2025 18:11

PriyanshTratiya removed request for cyw233, lolyu, sanjair-git, wangxin and xwjiang-ms December 3, 2025 18:11

PriyanshTratiya marked this pull request as ready for review December 3, 2025 21:19

PriyanshTratiya requested review from StormLiangMS, wangxin and yxieca as code owners December 3, 2025 21:19

r12f reviewed Dec 4, 2025

View reviewed changes

ansible/library/check_bgp_ipv6_routes_converged.py Show resolved Hide resolved

ansible/library/check_bgp_ipv6_routes_converged.py Outdated Show resolved Hide resolved

PriyanshTratiya changed the title ~~Feature/bgp flap phase 2~~ feature/bgp sessions admin flap test Dec 4, 2025

r12f mentioned this pull request Dec 4, 2025

Feature/route programming data #21523

Merged

10 tasks

github-actions bot requested review from cyw233, lolyu, r12f, sanjair-git and xwjiang-ms December 4, 2025 01:08

PriyanshTratiya removed request for cyw233, lolyu and xwjiang-ms December 4, 2025 01:08

github-actions bot requested a review from sanjair-git January 9, 2026 11:45

PriyanshTratiya removed request for cyw233 and sanjair-git January 9, 2026 12:11

bingwang-ms merged commit a4e2ecc into sonic-net:master Jan 12, 2026
21 checks passed

PriyanshTratiya mentioned this pull request Jan 21, 2026

updating the testplan for new test case and metrics measurement #22081

Open

11 tasks

PriyanshTratiya added Request for msft-202412 Branch Request for 202511 branch Request to backport a change to 202511 branch labels Jan 22, 2026

mssonicbld added the Cherry Pick Conflict_msft-202412 label Jan 22, 2026

vmittal-msft added the Approved for 202511 branch label Jan 30, 2026

mssonicbld added the Cherry Pick Conflict_202511 label Jan 30, 2026

PriyanshTratiya mentioned this pull request Feb 12, 2026

Cherry picking PR#21936 & #21520 #22375

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/bgp sessions admin flap test#21520

feature/bgp sessions admin flap test#21520
bingwang-ms merged 5 commits intosonic-net:masterfrom
PriyanshTratiya:feature/bgp-flap-phase-2

PriyanshTratiya commented Dec 3, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Dec 3, 2025

Uh oh!

azure-pipelines bot commented Dec 3, 2025

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Dec 4, 2025

Uh oh!

azure-pipelines bot commented Dec 4, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2026

Uh oh!

Uh oh!

mssonicbld commented Jan 30, 2026

Uh oh!

weiguo-nvidia commented Feb 9, 2026

Uh oh!

PriyanshTratiya commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

PriyanshTratiya commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Dec 3, 2025

Uh oh!

azure-pipelines bot commented Dec 3, 2025

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Dec 4, 2025

Uh oh!

azure-pipelines bot commented Dec 4, 2025

Uh oh!

azure-pipelines bot commented Jan 9, 2026

Uh oh!

Uh oh!

mssonicbld commented Jan 30, 2026

Uh oh!

weiguo-nvidia commented Feb 9, 2026

Uh oh!

PriyanshTratiya commented Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PriyanshTratiya commented Dec 3, 2025 •

edited

Loading